tide: add more metrics #539
Conversation
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
/test pull-prow-unit-test-race-detector-nonblocking |
pkg/tide/tide.go
Outdated
| retestsByAction: prometheus.NewCounterVec(prometheus.CounterOpts{ | ||
| Name: "tide_retests_by_action_total", | ||
| Help: "Total number of retests by action type (TRIGGER for serial, TRIGGER_BATCH for batch). Helps identify whether batch or serial testing is causing more retests.", | ||
| }, []string{ | ||
| "org", | ||
| "repo", | ||
| "branch", | ||
| "action", | ||
| }), |
There was a problem hiding this comment.
I do not think we need both tide_retests_by_action_total and tide_retests_total, if you need the latter you can get it from the former by aggregating. We should only have tide_retests_total but let it have action label.
pkg/tide/tide.go
Outdated
| if len(batchPending) == 0 && len(missings) > 0 && len(pendings) == 0 { | ||
| if act == Trigger { |
There was a problem hiding this comment.
Can you help me understand why this indicates a batch failure? I think we can be in this state simply because the HEAD moved and now a PR needs to be (maybe individually, not necessarily in a batch) retested?
pkg/tide/tide.go
Outdated
| batchFailures: prometheus.NewCounterVec(prometheus.CounterOpts{ | ||
| Name: "tide_batch_failures_total", | ||
| Help: "Total number of times a batch test completes but PRs move back to missing state (indicating batch failure). This is expensive as all PRs in the batch need retesting.", | ||
| }, []string{ | ||
| "org", | ||
| "repo", | ||
| "branch", | ||
| }), |
There was a problem hiding this comment.
Does this really need to be a Tide metric? Batch jobs are a separate type of a ProwJob, I guess we already have that number from crier (or plank maybe) in a metric that tracks job results?
Prucek
force-pushed
the
tide-add-metrics
branch
from
ec69c65 to
8f0cb89
Compare
|
Looks like all comments have been address, and the changes look good to me. /lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Prucek, smg247 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
6 participants
This PR adds more metrics to see how much time tide spends retesting.
🤖 Assisted by Claude.